Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iterators in a for-range loop #8871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use iterators in a for-range loop #8871

wants to merge 1 commit into from

Conversation

roman-kiselenko
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve sync.Map iterators with an implicit call

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Improve `sync.Map` iterators with an implicit call

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 23, 2024
@openshift-ci openshift-ci bot requested review from klihub and littlejawa December 23, 2024 10:26
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch 2 times, most recently from fbbca34 to 425cc8b Compare December 23, 2024 11:08
@sohankunkerkar
Copy link
Member

/retest

bitoku
bitoku reviewed Dec 23, 2024
View reviewed changes
server/container_events.go Outdated Show resolved Hide resolved
server/container_events.go Outdated Show resolved Hide resolved
server/container_events.go Outdated Show resolved Hide resolved
server/container_events.go Outdated Show resolved Hide resolved
server/container_events.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.07%. Comparing base (c956013) to head (a9e7d29).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8871      +/-   ##
==========================================
- Coverage   47.09%   47.07%   -0.02%     
==========================================
  Files         154      154              
  Lines       22138    22131       -7     
==========================================
- Hits        10425    10418       -7     
+ Misses      10644    10643       -1     
- Partials     1069     1070       +1

@roman-kiselenko
Copy link
Member Author

/retest

@roman-kiselenko roman-kiselenko mentioned this pull request Dec 24, 2024
Open
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 89a60c1 to e8572b5 Compare January 2, 2025 16:07
@haircommander
Copy link
Member

/approve

LGTM, thanks!

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@kwilczynski
Copy link
Member

/retest

@sohankunkerkar
Copy link
Member

/test ci-e2e-evented-pleg

@sohankunkerkar
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from e8572b5 to 128ad4a Compare January 10, 2025 20:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2025
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 824de8f to 77fe325 Compare January 10, 2025 20:55
@sohankunkerkar
Copy link
Member

It looks like your branch is not up-to-date. Could you rebase on top of the main branch? This PR should include only one commit.

@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 77fe325 to ef77a18 Compare January 10, 2025 21:21
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 6ad5325 to c956013 Compare January 10, 2025 21:34
@openshift-ci openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 10, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, roman-kiselenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, roman-kiselenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 327aaa2 to 2094dc6 Compare January 10, 2025 21:50
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 10, 2025
@roman-kiselenko roman-kiselenko force-pushed the refactor/for-loop-range branch from 2094dc6 to a9e7d29 Compare January 10, 2025 21:56
@bitoku
Copy link
Contributor

bitoku commented Jan 17, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

@bitoku bitoku Awaiting requested review from bitoku

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roman-kiselenko @sohankunkerkar @haircommander @kwilczynski @bitoku @openshift-merge-robot