-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [release-1.31] Cherry-pick changes from containers/image project #8843
base: release-1.31
Are you sure you want to change the base?
[WIP] [release-1.31] Cherry-pick changes from containers/image project #8843
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.31 #8843 +/- ##
=============================================
Coverage 46.75% 46.75%
=============================================
Files 153 153
Lines 22063 22063
=============================================
Hits 10316 10316
Misses 10679 10679
Partials 1068 1068 |
adding a |
Cherry-pick the following changes: - containers/image/pull#2636 - containers/image/pull#2643 Signed-off-by: Krzysztof Wilczyński <[email protected]>
369cb9f
to
6f49951
Compare
/retest |
/cc @cri-o/cri-o-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t spend too much time reviewing this, but based how I remember the code in this area not changing much over time, this looks correct.
What type of PR is this?
/kind bug
/assign kwilczynski
What this PR does / why we need it:
Manually cherry-pick changes from containers/image project.
These changes carry fixes that need to be backported to CRI-O.
Related:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?