Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [release-1.31] Cherry-pick changes from containers/image project #8843

Open
wants to merge 1 commit into
base: release-1.31
Choose a base branch
from

Conversation

kwilczynski
Copy link
Member

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from containers/image project.

These changes carry fixes that need to be backported to CRI-O.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner December 12, 2024 13:25
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024
@kwilczynski kwilczynski changed the title Cherry-pick changes from containers/image project [release-1.31] Cherry-pick changes from containers/image project Dec 12, 2024
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 12, 2024
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.75%. Comparing base (b031f89) to head (6f49951).
Report is 2 commits behind head on release-1.31.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.31    #8843   +/-   ##
=============================================
  Coverage         46.75%   46.75%           
=============================================
  Files               153      153           
  Lines             22063    22063           
=============================================
  Hits              10316    10316           
  Misses            10679    10679           
  Partials           1068     1068           

@haircommander
Copy link
Member

adding a
/hold
here because it"s not on a branch yet but change LGTM

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
Cherry-pick the following changes:

  - containers/image/pull#2636
  - containers/image/pull#2643

Signed-off-by: Krzysztof Wilczyński <[email protected]>
@kwilczynski kwilczynski force-pushed the feature/backport-image-updates-to-release-1.31 branch from 369cb9f to 6f49951 Compare January 1, 2025 21:58
@kwilczynski kwilczynski changed the title [release-1.31] Cherry-pick changes from containers/image project [WIP] [release-1.31] Cherry-pick changes from containers/image project Jan 1, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 1, 2025
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/cc @cri-o/cri-o-maintainers
/cc @mtrmac

@openshift-ci openshift-ci bot requested review from mtrmac and a team January 7, 2025 21:36
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t spend too much time reviewing this, but based how I remember the code in this area not changing much over time, this looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants