Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace $enable-rounded sass variable with individual classes #363

Closed
alee opened this issue Jun 7, 2018 · 3 comments
Closed

replace $enable-rounded sass variable with individual classes #363

alee opened this issue Jun 7, 2018 · 3 comments

Comments

@alee
Copy link
Member

alee commented Jun 7, 2018

consider removing the $enable-rounded: false; in _variables.scss and instead override specific elements that need squareness to have no border-radius

otherwise this appears to prevent all border-radius from badges buttons etc (needs further testing)

alee added a commit that referenced this issue Jun 7, 2018
@sgfost
Copy link
Contributor

sgfost commented Mar 15, 2023

bit of an ancient issue but where would we want sharp corners/rounded corners? Just about everything is squared off due to $enable-rounded. I think a lot of things tend to look nicer with the small border radius that bootstrap seems to default to but that's awfully subjective. Maybe smooth out button/badges and keep containers and such sharp?

@alee
Copy link
Member Author

alee commented Mar 15, 2023

I think the general sentiment was to support more finely grained / flexible UI designs instead of a one-size-fits-all approach that this variable setting was causing.

Will this still be an issue with the new Vue 3 build bootstrap 5 PR you're working on though?

@sgfost
Copy link
Contributor

sgfost commented Mar 15, 2023

How I'm handling the styles now is refactoring the existing stylesheets, which is how I ran into it. It still does the same thing in bootstrap 5. Ultimately it doesn't really matter too much, besides picking the default we'll use more to avoid tons of explicit overrides

hwelsters pushed a commit to hwelsters/comses.net that referenced this issue May 10, 2023
@alee alee closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants