fix(screen-orientation): `None of the requested orientations are supp…

…orted by the view controller` error on iOS (capawesome-team#101)
co-dax · Dec 13, 2023 · 89ab014 · 89ab014
1 parent bf8935b
commit 89ab014
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/smart-trainers-pump.md b/.changeset/smart-trainers-pump.md
@@ -0,0  1,5 @@
 ---
 '@capawesome/capacitor-screen-orientation': patch
 ---
 
 fix(ios): `None of the requested orientations are supported by the view controller` error
diff --git a/packages/screen-orientation/ios/Plugin/ScreenOrientation.swift b/packages/screen-orientation/ios/Plugin/ScreenOrientation.swift
@@ -30,7  30,9 @@ import Capacitor
             strongSelf.requestGeometryUpdate(orientationValue: nextOrientationValue, orientationMask: nextOrientationMask)
             ScreenOrientation.supportedInterfaceOrientations = nextOrientationMask
             UINavigationController.attemptRotationToDeviceOrientation()
-            strongSelf.requestGeometryUpdate(orientationValue: currentOrientationValue, orientationMask: currentOrientationMask)
             if #unavailable(iOS 16) {
                 strongSelf.requestGeometryUpdate(orientationValue: currentOrientationValue, orientationMask: currentOrientationMask)
             }
             strongSelf.notifyOrientationChangeListeners(orientationType)
             completion()
         }
@@ -55,7  57,7 @@ import Capacitor
         }
         completion(cachedOrientationType)
     }
-
     
     @objc private func requestGeometryUpdate(orientationValue: Int, orientationMask: UIInterfaceOrientationMask) {
         if #available(iOS 16, *) {
             let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene
@@ -98,7  100,7 @@ import Capacitor
         self.currentOrientationType = orientationType
         self.plugin.notifyOrientationChangeListeners(orientationType)
     }
-
     
     @objc private func convertOrientationValueToMask(_ orientationValue: Int) -> UIInterfaceOrientationMask {
         switch orientationValue {
         case UIInterfaceOrientation.landscapeLeft.rawValue: