Upstream #51
Open
Upstream #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- theres no need for an atom to track state if we just pass the class through in a functional implementation
- turns out the env* atom was abused harder than we thought - to be functional we have to pass the rule-index all around ... i see now why they used an atom.
- turns out the env* had a lot more hidden context - fixed incorrect classnames being bandied about
Why: * We want the ability to define separate media queries for a single element. This change addresses the need by: * Split up the media queries before building. * Recombine separate media queries. * Concat media queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is how you would approach the problem, but it's what we came up with. See here for more details: #50.
TBH this is a really bad PR and should definitely not be merged. It works, and this was the bare minimum set of changes we had to make to get everything working without the
env*context atom. A real refactor would be a much better solution, but we don't have the time.