FR: add build override options #1264
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dTechLife
changed the title
| @@ -243,7 243,8 @@ class DockerApi { | |||
| tarballFilePath: string, | |||
| buildLogs: BuildLog, | |||
| envVars: IAppEnvVar[], | |||
| registryConfig: DockerRegistryConfig | |||
| registryConfig: DockerRegistryConfig, | |||
| overrideOptions: string[] | undefined | |||
There was a problem hiding this comment.
Must be renamed to dockerBuildOverrideOptions
| @@ -268,6 269,7 @@ class DockerApi { | |||
| const optionsForBuild: Dockerode.ImageBuildOptions = { | |||
| t: imageName, | |||
| buildargs: buildargs, | |||
| ...overrideOptions, | |||
There was a problem hiding this comment.
Is this how it's passed to Dockerode? Isn't it using a key<>value pair structure?
There was a problem hiding this comment.
Great way to word that question; it isn't! I'll take a look at Dockerode and make sure I'm passing the variable correctly. :) Thank you for taking the time to review this for me!
I'll go through the concerns in the review, commit, build and test the functionality of the feature and change this from a draft after I confirm it works!
githubsaturn
force-pushed
the
master
branch
2 times, most recently
from
3e708d7 to
46e7e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't complete but I wanted to make sure I am going down the right path.
I brought up in an old issue, I'd like to know more about the implications of making this change.
I believe caprover uses /var/run/docker.sock to spawn build containers, with this change to the server a user should be able to add extra build option flags to be passed to the docker build command.
https://github.com/caprover/caprover/blob/master/CONTRIBUTING.md
TODO: