Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/git hooks - Rename pre-commit-hooks package to git-hooks package #1322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor/git hooks - Rename pre-commit-hooks package to git-hooks package #1322

wants to merge 4 commits into from

Conversation

use-the-fork
Copy link
Contributor

The upstream package has been renamed so this is a quick refractor to update that.

Issues Addressed:

@domenkozar
Copy link
Member

This needs a rename for the nixos option and redirect for the docs url

@use-the-fork
Copy link
Contributor Author

This needs a rename for the nixos option and redirect for the docs url

So I was going to ask you about this. I didn't want it to be a breaking change by renaming the base option from pre-commit.hooks to git-hooks.pre-commit.

since mkRenamedOptionModule doesn't work in bulk with submodules and the modules coming from pre commit are dynamic anyone that pulls the latest release would have to rename immediately or an error would be thrown.

The other option would be to add an assertion and be explicit about the name change there. Let me know and I will make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename pre-commit.hooks to git.hooks
2 participants
@use-the-fork @domenkozar