Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): filter out more obvious variables for base64 #6889

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Dec 3, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Filter out more obvious FPs

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances the base64 false positive detection regex in the detector_utils.py file to filter out more obvious variables and adds a test case in test_secrets.py.

TopicDetails
Add test case Adds a new test case in test_secrets.py to verify the improved base64 false positive detection
Modified files (1)
  • tests/unit/test_secrets.py
Latest Contributors(2)
UserCommitDate
[email protected]...feat-secrets-eliminate...May 22, 2024
bo156feat-secrets-used-10-c...December 07, 2023
Improve B64 detection Updates the B64_FP_REGEX in detector_utils.py to filter out more obvious false positives in base64 secret detection
Modified files (1)
  • checkov/secrets/plugins/detector_utils.py
Latest Contributors(2)
UserCommitDate
[email protected]...feat-secrets-eliminate...May 22, 2024
maxamelfeat-secrets-fix-entro...March 17, 2024
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 changed the title chore(secrets): filter out more obvious variables for base64 fix(secrets): filter out more obvious variables for base64 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant