Skip to content

Commit

Permalink
Explicitly tag targets that don't build on Build Kite (google#49)
Browse files Browse the repository at this point in the history
Some targets are tagged manual for other reasons and manual really just
means "don't build this in wildcards", which is a human-focused
distinction. For build bots, we can now use `bazel query` (which
ignores "manual") piped to `bazel test` to build and test all targets
in parallel (more important as we get more tests).

Tested:
Locally ran
```shell
bazel query //...   @llvm-project//... \
  | xargs bazel test \
    --config=rbe \
    --test_output=errors \
    --test_tag_filters=-nobuildkite \
    --build_tag_filters=-nobuildkite
```
  • Loading branch information
GMNGeoffrey authored Oct 13, 2020
1 parent b5b13aa commit 849278b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 11 deletions.
12 changes: 8 additions & 4 deletions llvm-bazel/llvm-project-overlay/llvm/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2091,7 2091,8 @@ cc_library(
"-lxml2",
],
tags = [
"manual", # TODO(gcmn): Fix remote execution and re-enable
"manual", # External dependency (libxml)
"nobuildkite", # TODO(gcmn): Fix remote execution and re-enable
],
deps = [
":Support",
Expand Down Expand Up @@ -2142,7 2143,8 @@ cc_library(
copts = llvm_copts ["-DHAVE_LIBPFM=1"],
defines = ["LLVM_EXEGESIS_INITIALIZE_NATIVE_TARGET=InitializeX86ExegesisTarget"],
tags = [
"manual", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
"manual", # External dependency (libpfm4)
"nobuildkite", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
],
deps = [
":AllTargetsAsmParsers",
Expand Down Expand Up @@ -2534,7 2536,8 @@ cc_binary(
copts = llvm_copts ["-DHAVE_LIBPFM=0"],
stamp = 0,
tags = [
"manual", # TODO(chandlerc): Remove when the library builds.
"manual", # TODO(chandlerc): Enable when the library builds.
"nobuildkite", # TODO(chandlerc): Enable when the library builds.
],
deps = [
":AllTargetsAsmParsers",
Expand Down Expand Up @@ -2815,7 2818,8 @@ cc_binary(
copts = llvm_copts,
stamp = 0,
tags = [
"manual", # TODO(gcmn): Fix remote execution and re-enable
"manual", # TODO(gcmn): External dependency (through WindowsManifest)
"nobuildkite", # TODO(gcmn): Re-enable when WindowsManifest builds
],
deps = [
":MtTableGen",
Expand Down
19 changes: 12 additions & 7 deletions llvm-bazel/llvm-project-overlay/mlir/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 163,8 @@ cc_library(
"include/mlir-c/Bindings/Python/Interop.h",
],
tags = [
"manual", # TODO(gcmn): Add support for this target
"manual", # External dependency
"nobuildkite", # TODO(gcmn): Add support for this target
],
deps = [
":CAPIIR",
Expand Down Expand Up @@ -3237,7 3238,8 @@ cc_library(
name = "tools/libcuda-runtime-wrappers",
srcs = ["tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp"],
tags = [
"manual", # TODO(gcmn): Add support for this target
"manual", # External dependency
"nobuildkite", # TODO(gcmn): Add support for this target
],
deps = [
":mlir_c_runner_utils",
Expand All @@ -3252,7 3254,8 @@ cc_binary(
name = "tools/libcuda-runtime-wrappers.so",
linkshared = True,
tags = [
"manual", # TODO(gcmn): Add support for this target
"manual", # External dependency
"nobuildkite", # TODO(gcmn): Add support for this target
],
deps = [":tools/libcuda-runtime-wrappers"],
)
Expand All @@ -3266,7 3269,7 @@ cc_library(
"tools/mlir-vulkan-runner/VulkanRuntime.h",
],
tags = [
"manual", # Requires an external dependency.
"manual", # External dependency
],
deps = [
":IR",
Expand All @@ -3286,7 3289,7 @@ cc_binary(
srcs = ["tools/mlir-vulkan-runner/vulkan-runtime-wrappers.cpp"],
linkshared = True,
tags = [
"manual", # Requires an external dependency.
"manual", # External dependency (through VulkanRuntime)
],
deps = [
":VulkanRuntime",
Expand All @@ -3299,7 3302,8 @@ cc_binary(
srcs = ["tools/mlir-cuda-runner/mlir-cuda-runner.cpp"],
data = [":tools/libcuda-runtime-wrappers.so"],
tags = [
"manual", # TODO(gcmn): Add support for this target
"manual", # External dependency
"nobuildkite", # TODO(gcmn): Add support for this target
],
deps = [
":AllPassesAndDialectsNoRegistration",
Expand Down Expand Up @@ -3333,7 3337,8 @@ cc_binary(
"//mlir/test/mlir-cpu-runner:libmlir_runner_utils.so",
],
tags = [
"manual", # TODO(gcmn): Add support for this target
"manual", # External dependency
"nobuildkite", # TODO(gcmn): Add support for this target
],
deps = [
":AllPassesAndDialectsNoRegistration",
Expand Down

0 comments on commit 849278b

Please sign in to comment.