Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce no_std #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce no_std #14

wants to merge 3 commits into from

Conversation

hoijui
Copy link
Contributor

@hoijui hoijui commented Dec 19, 2023

To be honest, I think this makes little sense for this library.
I did it, because I never implemented it before, and wanted to try.

I also did something that is discouraged:
Having a no_std feature which has to be manually enabled
whenever feature std is disabled.
This allows to not compile dependency tinyvec when
feature std is enabled.
The alternative would be, to remove the optional = true
from tinyvec in Cargo.toml,
remove feature no_std,
and live with tinyvec being compiled in the std case,
even though it is not used there.

I can imagine this would be ok to have around
as a separate branch in this repo,
but would probably not merge it into master.

@becheran
Copy link
Owner

😎 in general I like the idea. But as you already wrote I don't think there are a lot of people wanting this. But who knows. If more people would comment on this pr I am not fully against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants