Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I think this makes little sense for this library.
I did it, because I never implemented it before, and wanted to try.
I also did something that is discouraged:
Having a
no_std
feature which has to be manually enabledwhenever feature
std
is disabled.This allows to not compile dependency
tinyvec
whenfeature
std
is enabled.The alternative would be, to remove the
optional = true
from
tinyvec
in Cargo.toml,remove feature
no_std
,and live with
tinyvec
being compiled in thestd
case,even though it is not used there.
I can imagine this would be ok to have around
as a separate branch in this repo,
but would probably not merge it into master.