Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should downloading a CSV/XLSX for a data dictionary for a published MR with draft changes download the published or draft version? #583

Open
david-fong-bc opened this issue Dec 10, 2024 · 1 comment
Open

Should downloading a CSV/XLSX for a data dictionary for a published MR with draft changes download the published or draft version? #583

david-fong-bc opened this issue Dec 10, 2024 · 1 comment
Assignees
@NicoledeGreef
Labels
question Further information is requested

Comments

@david-fong-bc
Copy link

question Further information is requested

Current behaviour

  1. Create MR
  2. Create data dictionary with one entry
  3. Publish the MR
  4. Add a new entry to the data dictionary
  5. Download a CSV or XLSX of the data dictionary
  6. Observe that it is for the published version of the MR- it doesn"t have the second entry of the data dictionary added in the current draft.

This feels weird to me, given that the data dictionary download feature is part of the edit interface / workflow. It would be more intuitive to me if the draft version were downloaded. What do we think about this?
@david-fong-bc david-fong-bc added the question Further information is requested label Dec 10, 2024
@NicoledeGreef
Copy link
Collaborator

As a user that is looking for info, I would expect that only published metadata, including dictionary, is shown. Only published content shows up in search results.

But as an editor this is an interesting question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicoledeGreef NicoledeGreef

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicoledeGreef @david-fong-bc