Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now specify custom commands. This had been documented previously as using a
:
separator between module name and command in the string, but it was not implemented. Additionally, that strategy wouldn't have worked for git-repo-URLs (as a protocol or port would contain a:
before the name was complete). So instead, I created a simple object format (with propertiesname
,repoUrl
, andcommand
) that can be specified alongside strings.I did my best not to editorialize on style or do any other refactors in the process, so even though this is a significant change, I tried to make it as non-disruptive to you and your style as I could.
A couple notes:
:
for non-URL module names, but since it had no useful effect previously, I doubt anyone will be broken by the fact I removed it in this commitnpm install https://github.com/testdouble/testdouble.js
works, so perhaps the custom work withggit
isn't necessary? I only glanced at it.