26 Update frontend for api changes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisduvivier
changed the title
paulinevos
reviewed
Nov 27, 2024
| export const getCreateAppUrl = (slug: ProjectSlug,) => { | ||
|
|
||
|
|
||
| return `http://localhost:8081/api/v3/apps/${slug}` |
There was a problem hiding this comment.
Where are these references to localhost generated from?
There was a problem hiding this comment.
Hmm, that's because I changed the BADGEHUB_API_BASEURL env var locally and to be able to get the new definitions generated with orval. I'll do a batch replace, thanks!
There was a problem hiding this comment.
But that actually also brings me to the point that this should not be hardcoded in the generated files.
I'll check if I can change that.
There was a problem hiding this comment.
OK updated now:
c52220f
francisduvivier
force-pushed
the
26-improve-type-safety-for-db-queries
branch
from
932e17f to
8a90cb3
Compare
edwinm
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the frontend compatible with badgehub-api changes that were done in preparation for app uploads:
Relates to API pr's:
badgeteam/badgehub-api#35
badgeteam/badgehub-api#34