Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder name in source target is dashed (underscores are needed) #43

Open
josefglatz opened this issue Sep 26, 2022 · 3 comments
Open

Folder name in source target is dashed (underscores are needed) #43

josefglatz opened this issue Sep 26, 2022 · 3 comments

Comments

@josefglatz
Copy link

Hi, it seems like this folder needs to be with underscores, as also the phpstorm typoscript plugin uses this folder for auto completion and also the convention (at least in my head) wants underscores?

What do you think @o-ba ?

Cheers, Josef
@o-ba
Copy link
Member

o-ba commented Sep 26, 2022

Hi @josefglatz,
could you please specify which folder you're referring to?
Thanks, Oli

@josefglatz
Copy link
Author

packages/ or the default of make src/extensions.

My package vendorname/foo-bar with extension-key "foo_bar" has a folder named src/extensions/foo-bar instead of src/extensions/foo_bar.

@o-ba
Copy link
Member

o-ba commented Sep 27, 2022

Oke, thanks for the clarification. For this case we should allow to specify an alternative extension target in the make:extension command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josefglatz @o-ba