Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black formatting in multiple versions of python #1420

Open
bandophahita opened this issue Jun 12, 2024 · 3 comments
Open

black formatting in multiple versions of python #1420

bandophahita opened this issue Jun 12, 2024 · 3 comments

Comments

@bandophahita
Copy link
Contributor

bandophahita commented Jun 12, 2024

I'm currently working on a draft PR to add type hint annotations and I noticed black installs an older version in python3.6 & python3.7. This is causing inconsistent results in tox due to changes in formatting between older and newer versions of black.

See: https://github.com/atlassian-api/atlassian-python-api/actions/runs/9490554332 for the results.

There are a couple of options I can see:

  • force black to an older version in all supported versions of python
  • have black only check in a subset or even singular version of python.
    • this will be tricky as the current testing is done in tox then in docker; for as long as the package supports older (no longer supported) versions of python.
  • drop support for older python versions.
    • seems above my paygrade to suggest, but would eliminate a bunch of other support issues
  • add # fmt: skip in the places where versions of black differ (this does not appear to work)

My question for the maintainers; what do you suggest?

@gonchik
Copy link
Member

gonchik commented Jun 13, 2024

@bandophahita
based on the stats :
https://pypistats.org/packages/atlassian-python-api

image

time to skip python2 version with proper announce.

@bandophahita
Copy link
Contributor Author

bandophahita commented Jun 13, 2024

How about dropping unsupported python3 versions?
3.7 was end-of-life last year. 3.6 ended in 2021.
https://devguide.python.org/versions/

image

@gonchik
Copy link
Member

gonchik commented Jun 14, 2024

@bandophahita Indeed, let me adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants