Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[IOTDB-6353] replace cglib to byte-buddy (#14426)" #14497

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

image

Performance degradation was observed

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (55b37e0) to head (9b39c01).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
.../client/sync/SyncThriftClientWithErrorHandler.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14497       /-   ##
============================================
  Coverage     39.60%   39.62%    0.01%     
  Complexity      185      185              
============================================
  Files          4334     4334              
  Lines        275866   275910       44     
  Branches      33533    33531       -2     
============================================
  Hits         109267   109328       61     
  Misses       166599   166582      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HTHou
Copy link
Contributor

HTHou commented Dec 19, 2024

Should we try some newer versions before we do this revert?
https://github.com/raphw/byte-buddy/releases

@HTHou
Copy link
Contributor

HTHou commented Dec 20, 2024

ok, the latest version of byte-buddy still has the problem.
image

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit f215c42 into master Dec 20, 2024
44 of 47 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the queryTest branch December 20, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants