Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make Transaction: Typed2718 #1735

Closed
mattsse opened this issue Dec 3, 2024 · 1 comment
Closed

[Feature] Make Transaction: Typed2718 #1735

mattsse opened this issue Dec 3, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Dec 3, 2024

Component

consensus, eips, genesis

Describe the feature you would like

the transaction trait currently has its own fn ty function.

we can unify this with the newer Typed2718 trait by

  1. remove fn ty from trait Transaction
  2. require trait Transaction: Typed2718

Additional context

No response
@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Dec 3, 2024
@nuts-rice nuts-rice mentioned this issue Dec 3, 2024
Merged
4 tasks
@nadtech-hub
Copy link
Contributor

🤚

@mattsse mattsse closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @nadtech-hub