fix: fix the client cli parser

alexcg1 · Jun 2, 2020 · 73d17ba · 73d17ba
1 parent f1acce3
commit 73d17ba
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/jina/main/parser.py b/jina/main/parser.py
@@ -429,7  429,7 @@ def set_client_cli_parser(parser=None):
                      help='randomize the doc_id, if this is set then `first_request_id` is ignored')
     gp1.add_argument('--timeout-ready', type=int, default=10000,
                      help='timeout (ms) of a pea is ready for request, -1 for waiting forever')
-    gp1.add_argument('--filter-by', type=str, action='append',
     gp1.add_argument('--filter-by', type=str, nargs='*',
                      help='field names to query on')
     return parser
 

diff --git a/tests/test_helper.py b/tests/test_helper.py
@@ -0,0  1,18 @@
 import unittest
 from tests import JinaTestCase
 from jina.main.parser import set_client_cli_parser
 from jina.helper import get_parsed_args
 
 
 class MyTestCase(JinaTestCase):
     def test_get_parsed_args_parse_list(self):
         kwargs = {'filter-by': ['a', 'b']}
         parser = set_client_cli_parser()
         args, p_args, un_args = get_parsed_args(kwargs, parser)
         self.assertEqual(len(args), 3)
         self.assertEqual(len(p_args.filter_by), 2)
         self.assertEqual(len(un_args), 0)
 
 
 if __name__ == '__main__':
     unittest.main()