Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated kargo ui snapshot #2914

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Nov 11, 2024

fixes #2883

before:
image

after:
P5esNo604TwM3IYa7vyksyaJQ

Signed-off-by: Faeka Ansari <[email protected]>
@fykaa fykaa self-assigned this Nov 11, 2024
@fykaa fykaa requested review from a team as code owners November 11, 2024 20:46
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 14fd88e
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67813369f96ecf0008183a34
😎 Deploy Preview https://deploy-preview-2914.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.55%. Comparing base (6c10f68) to head (14fd88e).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
+ Coverage   49.92%   51.55%   +1.63%     
==========================================
  Files         275      288      +13     
  Lines       24668    26188    +1520     
==========================================
+ Hits        12315    13502    +1187     
- Misses      11676    11960     +284     
- Partials      677      726      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

Where are all the little Argo logos coming from? Is there a reason that these should be here?

@fykaa
Copy link
Contributor Author

fykaa commented Nov 13, 2024

it shows that Kargo complements Argo CD for Kubernetes
I have adopted it from the kargo site

@krancour
Copy link
Member

it shows that Kargo complements Argo CD for Kubernetes
I have adopted it from the kargo site

I see.

That site is really more of a marketing thing and I can see where it might be beneficial in that context to underscore the integration with Argo CD.

Our primary goal with technical documentation isn"t to sell so much as to provide useful information. I don"t believe plastering the Argo logo all over the screenshot is helpful in this context.

I would prefer seeing a screen capture like this one, but without the Argo logos.

@krancour
Copy link
Member

@fykaa can we put some closure on this PR please?

Signed-off-by: Faeka Ansari <[email protected]>
@fykaa fykaa marked this pull request as ready for review January 10, 2025 14:51
@krancour krancour added this pull request to the merge queue Jan 10, 2025
Merged via the queue into akuity:main with commit 83115e5 Jan 10, 2025
19 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
Signed-off-by: Faeka Ansari <[email protected]>
(cherry picked from commit 83115e5)
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

fykaa added a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update kargo UI snapshot in overview
3 participants