Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate CFL time step calculation #271

Open
stvdwtt opened this issue Apr 16, 2024 · 2 comments
Open

Automate CFL time step calculation #271

stvdwtt opened this issue Apr 16, 2024 · 2 comments
Assignees

Comments

@stvdwtt
Copy link
Collaborator

stvdwtt commented Apr 16, 2024

It should be straightforward to compute the global minimum time step for a simulation, assuming that we know the max thermal conductivity, the minimum coarse mesh element size, and the maximum number of refinements. This would allow us to make it so the user doesn't need to specifically pick the time step size, which would make things easier. We could add a user-specified safety factor so they can decrease the time step if desired.

Later on we could do a more sophisticated version of this where we adapt based on the layer that we're on, but that's out of scope for now.

@stvdwtt stvdwtt self-assigned this Apr 16, 2024
@Rombur
Copy link
Member

Rombur commented May 6, 2024

This should be high on our priority list. Right now it's really difficult for users to pick a good time step a priori. It's really cumbersome to use adamantine with Slicer 2

@stvdwtt
Copy link
Collaborator Author

stvdwtt commented Sep 8, 2024

Note to myself here, use dealii.GridTools::minimal_cell_diameter().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants