Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Network Error Popup on Test tab when the backend is not up or not available #541

Open
anusha5695 opened this issue Nov 7, 2020 · 4 comments
Open

Show Network Error Popup on Test tab when the backend is not up or not available #541

anusha5695 opened this issue Nov 7, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@anusha5695
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently when the server is not up, Tests tab don't show any network error popup. Because of this the user may go ahead and try creating tests

Describe the solution you'd like
Show Network Error popup in the same way it's done for Last scheduled runs Tab
@syncush
Copy link
Collaborator

syncush commented Nov 8, 2020

@enudler In general, I think we need better pop up messages for down services, in that case, we only have the predator backend as a service, should the UI pool for liveness?

@enudler
Copy link
Collaborator

enudler commented Nov 8, 2020

@syncush not sure if it's a must or just fix the popup when the predator is down
I would go with a new design of banners instead of our error popup @manorlh

@enudler enudler added the good first issue Good for newcomers label Nov 10, 2020
@anusha5695
Copy link
Contributor Author

anusha5695 commented Nov 10, 2020 •
edited
Loading

Hi @enudler, wouldn't we want to keep the behaviour consistent between all the tabs?

Currently last scheduled runs just shows a netwrok errorplain popup

@enudler
Copy link
Collaborator

enudler commented Nov 11, 2020

yes @anusha5695
do you want to handle this issue?

@NivLipetz NivLipetz mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enudler @syncush @anusha5695