Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent file deletion when merging with a blank line block #1274

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lamtuanamc
Copy link

@lamtuanamc lamtuanamc commented Nov 25, 2024

fixed #605

Description:

  • Fixed an issue where an file block was unintentionally deleted when merging with a blank line block.
  • Adjusted logic to retain the file block if the next block is blank and only delete the blank block.
  • Ensured proper merging behavior when the next block contains text (delete the file block and retain the text).
Screen.Recording.2024-11-25.at.15.28.03.mov

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Nov 27, 2024 9:53am

Copy link

vercel bot commented Nov 25, 2024

@lamtuanamc is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@lamtuanamc lamtuanamc changed the title Fix: Prevent image deletion when merging with a blank line block Fix: Prevent file deletion when merging with a blank line block Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove blank line under a 'none' content block will remove 'none' block together
1 participant