Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bullet 4 instructions in git_basics.md #28547

Closed
wants to merge 2 commits into from
Closed

Update bullet 4 instructions in git_basics.md #28547

wants to merge 2 commits into from

Conversation

newtreenoh
Copy link

@newtreenoh newtreenoh commented Aug 2, 2024 •
edited
Loading

Edited bullet 4 in Use the Git workflow for clarity

Because

The instructions in the bullet 4 were a little confusing.

This PR

Edited bullet 4 in Use the Git workflow for clarity...for clarity. Lol.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@newtreenoh
Update git_basics.md
c07e1be 
Edited TheOdinProject#4 in Use the Git workflow for clarity
@github-actions github-actions bot added the Content: Git Involves Git content label Aug 2, 2024
@01zulfi 01zulfi requested review from a team and zachmmeyer and removed request for a team August 2, 2024 13:09
zachmmeyer
zachmmeyer requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@zachmmeyer zachmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small suggestion to your contribution.
I would also ask that you look at the Pull Request Requirements in your PR description, as you haven't checked anything off. It involves setting the title of your PR to something other than Updating file.
You're also accidentally referencing an issue when you say #4, you could say bullet 4.

git/foundations_git/git_basics.md Outdated Show resolved Hide resolved
@zachmmeyer zachmmeyer assigned zachmmeyer and newtreenoh and unassigned zachmmeyer Aug 2, 2024
@newtreenoh newtreenoh changed the title Update git_basics.md Update bullet 4 instructions in git_basics.md Aug 3, 2024
@newtreenoh
Copy link
Author

Hi @zachmmeyer thanks for the review. The suggestions have been implemented. Please could you let me know if anything else required? Thanks!

@zachmmeyer
Copy link
Contributor

@newtreenoh The guidelines suggest the title should be something more like Git Basics: Add clarity to instructions.
I want to make sure we get it right before this gets locked in, as this is your first.

The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
The intention should be that you do what's in the template and check it off as it's completed, including checking your work with the markdown tool.

@zachmmeyer
Copy link
Contributor

@newtreenoh checking in if you're good to make the changes I requested

@zachmmeyer
Copy link
Contributor

Closing due to no response. This pull request can be reopened in the future if the changes can be made.

@zachmmeyer zachmmeyer closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmmeyer zachmmeyer zachmmeyer requested changes

Assignees

@newtreenoh newtreenoh

Labels
Content: Git Involves Git content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newtreenoh @zachmmeyer