-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous Code: Visualization Vids of Event Loop and Promises #27811
Conversation
I found these videos extra helpful in further visualizing how JavaScript works in the background with the Browser. I included it in the Assignment section because I felt it was that useful, but can decide if want to include them or not. Also put them in position 4, 5 because I felt that learning order was best. Thank you for all that y'all do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for making this PR! Sorry for the delay this got lost in my notifications.
One change request and this should be good.
@@ -75,7 75,9 @@ Of course, there are many more occasions where one would want to use Promises be | |||
1. Read this [Promises article](https://davidwalsh.name/promises). It's a good starting place and it's short and to the point. | |||
2. Watch this [Promises video](https://youtu.be/DHvZLI7Db8E). It's a good place to get a feel for how one might actually use promises in the wild. | |||
3. Watch this [What is Event Loop? video](https://www.youtube.com/watch?v=8aGhZQkoFbQ) to understand how asynchronous code works in JavaScript. | |||
4. Read [promise basics](https://javascript.info/promise-basics), which is an excellent resource for beginners. | |||
4. Watch this [Event Loop - Visualized video](https://www.youtube.com/watch?v=8aGhZQkoFbQ) to further understand the Event Loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is a repeat of the previous video?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they are just additional, repetitive videos. But thought the repetition and visualization were helpful in solidifying the knowledge. But yeah, can include in Additional resources instead, or if not necessary, then no need to include at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might be talking past each other, I mean that it looks like your Event Loop - Visualized
video is the same video that's linked under the What is Event Loop?
link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh I see, sorry my mistake. Have included the updated link in my second commit.
Corrected it to be like below:
4. Watch this Event Loop - Visualized video to further understand the Event Loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved a couple merge conflicts, thanks!
Also sorry this got held up so long again, in the future if a maintainer requests changes on your PR please click the "request re-review" button once you've addressed the changes, makes it a bit easier for us to see when we need to take another look at a PR 🙂
Because
Videos are extra helpful in further visualizing how JavaScript works in the background with the Browser.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section