Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import TFunction type from react-i18next for proper typing #7398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

import TFunction type from react-i18next for proper typing #7398

wants to merge 1 commit into from

Conversation

zoran995
Copy link
Collaborator

What this PR does

Fixes #

TFunction type should be imported from react-i18next instead of i18next directly. It will cause issues in new versions of react

Test me

Those are typeonly changes so it tested by CI

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@zoran995 zoran995 requested a review from ljowen December 23, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljowen ljowen Awaiting requested review from ljowen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zoran995