Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Skip Executable Categories When API Keys Missing #848

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

@HuanzhiMao HuanzhiMao commented Dec 20, 2024

This PR improves the behavior of the generation and evaluation pipeline. When executable categories are involved and API keys are not provided in the .env file, instead of throwing an error, the affected categories will now be skipped. This enhancement provides a smoother experience for first-time users.

  1. What will happen to overall score? What would be the difference between score on BFCL official leaderboard vs. without Executable?

If the API Key is not provided, that category will not be evaluated and will be treated as 0 by default in the overall score calculation, which means the overall score (and the one on the leaderboard) will be hurt if the API Keys are not supplied. PR #849 should make things more clear.

  1. What percentage of executable are there?

310 in total, out of 4751 entries.

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Dec 20, 2024
Copy link
Collaborator

@Fanjia-Yan Fanjia-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Change LGTM. Please add in PR description:

  1. What will happen to overall score? What would be the difference between score on BFCL official leaderboard vs. without Executable?
  2. What percentage of executable are there?

@HuanzhiMao
Copy link
Collaborator Author

Code Change LGTM. Please add in PR description:

  1. What will happen to overall score? What would be the difference between score on BFCL official leaderboard vs. without Executable?
  2. What percentage of executable are there?

Updated.

@HuanzhiMao HuanzhiMao merged commit 5ed29e2 into ShishirPatil:main Dec 21, 2024
@HuanzhiMao HuanzhiMao deleted the optional-api-key branch December 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-General General BFCL Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants