Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage for slas commands #288

Open
tobiaslohr opened this issue Feb 3, 2022 · 4 comments
Open

Test coverage for slas commands #288

tobiaslohr opened this issue Feb 3, 2022 · 4 comments
Labels
task

Comments

@tobiaslohr
Copy link
Contributor

tobiaslohr commented Feb 3, 2022 •
edited
Loading

#270 has introduced as breaking change as we've upgraded to a new major version of node-fetch. This caused slas commands to fail, reported in #280. A fix has been provided as part of #285. However, we should add unit tests and CLI functional tests to have some safeguards in place to prevent this from happening again.
@tobiaslohr
Copy link
Contributor Author

@hnestmann @johnboxall @jbachelet Any thoughts from your side?

@tobiaslohr tobiaslohr added the task label Feb 3, 2022
@hnestmann
Copy link
Collaborator

Yes I am fully on board to increase test coverage. Howeber - would unit tests help if dependencies change? Maybe we should think about integration tests with github actions or the like

@tobiaslohr
Copy link
Contributor Author

tobiaslohr commented Feb 3, 2022 via email •
edited
Loading

@hnestmann
Copy link
Collaborator

I will add unit tests for sure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiaslohr @hnestmann