Add base_sequence to sample.sobol
#617
Open
42
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you mean replace this implementation with what is in SciPy completely? |
|
Yeah to see how the new functions can be used on our side. Same goes for Sobol' indices themselves |
|
Sorry for the long delay in response. I wonder if we can make the target_shape = (2 * D, N)
seq = base_sequence(target_shape)Just a thought... Otherwise I am fine with the current implementation |
|
I see what you mean. I am not sure, do you have a use case yourself? This param is already questionable 😅 I don't mind adding though if you want. At some point we might either way to revisit the whole API (sad CZI 😓) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do this for a project to change the sampling method.
I am not sure about this and maybe we should start thinking about using the new SciPy machinery.
What do you think?