[flang][OpenMP][DoConcurrent] Support fir.shape_shift values
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the last change I had to make in order to compile LBL's inference engine to device (not able to successfully run on the device yet becuase we still miss some stuff related to mapping). Therefore, I think with this change, the |
|
Ping 🔔! Please take a look when you have a chance. |
mjklemm
approved these changes
Nov 29, 2024
|
One more ping 🔔! Let me know if there are any objections to merging this PR. |
skatrak
approved these changes
Dec 3, 2024
Extends support for shaped values by adding support for values whose shaped are defined by `fir.shapeshift` types. To that end, we add maps to store all the info from which we can recreate the shape of the mapped object.
ergawy
force-pushed
the
support_shape_shift_values
branch
from
658c99e to
7969a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends support for shaped values by adding support for values whose shaped are defined by
fir.shapeshifttypes. To that end, we add maps to store all the info from which we can recreate the shape of the mapped object.