Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Move OS score_real_collection to async/await and add progressbars #42

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP: Move OS score_real_collection to async/await and add progressbars #42

wants to merge 7 commits into from

Conversation

theelderbeever
Copy link
Collaborator

Reorganized some code to allow for better utilization of the Os rate limits. Provides roughly a 5x speed up in scoring a collection off the api.

image

vickygos
vickygos reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@vickygos vickygos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also recommend running: poetry run pytest -k test_testset_resolver --run-resolvers and the other tests to make sure the resolver works as expected!

pyproject.toml Show resolved Hide resolved
open_rarity/resolver/opensea_api_helpers.py Outdated Show resolved Hide resolved
open_rarity/resolver/opensea_api_helpers.py Outdated Show resolved Hide resolved
open_rarity/resolver/opensea_api_helpers.py Show resolved Hide resolved
open_rarity/resolver/opensea_api_helpers.py Outdated Show resolved Hide resolved
@theelderbeever theelderbeever force-pushed the theelderbeever/async-api-calls branch from 4afabc4 to 395923d Compare September 19, 2022 17:14
@theelderbeever theelderbeever mentioned this pull request Sep 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vickygos vickygos vickygos left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theelderbeever @vickygos