Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource selector UI #4556

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

trenser-rohith
Copy link

@trenser-rohith trenser-rohith commented Nov 29, 2024

Context

Use the current google cloud data store configuration UI components to show a datasource selection UI for the use to switch the current datasource to a different one configured in the config file. This will enable the users to switch the data sources without the need to taking a new build.

datasource.selection.mp4

Changes & Results

  • Added new DataSourceConfigurationApi file to provide the data objects to be shown when selecting the datasource selector UI.
  • Added a type prop to DatasourceConfigurationComponent to reuse it for both datasource selection and cloud datasource configuration
  • Added this component in the StudyListFilter component

Testing

  • Load worklist page
  • Click on the icon shown near to the datsource text
  • Check if the data sources configured in the config file is getting listed
  • Click the select button
  • Check if the data source shown in the filter component has changed and the new study list has been loaded

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 20.12
  • Browser: Chrome 131.0.6778.86

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit e536f26
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/675952fc792b3c000830c117
😎 Deploy Preview https://deploy-preview-4556--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e536f26
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/675952fce951f40008e4e939
😎 Deploy Preview https://deploy-preview-4556--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trenser-rohith trenser-rohith marked this pull request as ready for review December 2, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant