chore: improve task flow for native core deps #10591
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as a draft.
Currently we need to manually build ui-mobile-base and winter-cg internal packages before building core since core itself need the artifacts from these packages.
This PR changes it so we just need to run
copy-native-depsand we can leverage nx caching. We could makecopy-native-depsa dependency ofbuildbut it'd requirebuildto be ran only from a mac machine, even if not changing any iOS source (currently this works by storing the artifcats themselves in git).Thoughts on this?