Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for FASTQs with UMI in header #281

Open
pansapiens opened this issue Aug 9, 2023 · 0 comments
Open

Add sanity check for FASTQs with UMI in header #281

pansapiens opened this issue Aug 9, 2023 · 0 comments
Assignees

Comments

@pansapiens
Copy link
Collaborator

pansapiens commented Aug 9, 2023

For the nf-core/rnaseq wrapper, when the Advanced "UMI" option is selected (to pass --with-umis), we should do a sanity check on the user provided FASTQs to ensure they actually have UMIs in the header and fail fast if they don"t.

Otherwise, the pipeline runs until it fails on umitools with an error about unequal UMI lengths, eg "AssertionError: not all umis are the same length(!): 4 - 5".

We could go further, and make a "Use UMIs" dropdown option "auto" by default - checking if UMIs are present and throwing the --with-umis option, unless "Use UMIs" is "no".

@pansapiens pansapiens self-assigned this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant