Convert datetime to julian automatically in sunpos #91
9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #90 for the case of
sunpos
(perhaps there are other cases that should also be implemented). Because of the::DateTime
type signature it is hard to misuse these methods (i.e. you can't accidentally pass a Julian date into them) so I think the cost of adding the implicit conversions is low. Especially compared to the convenience and risk of misusing explicit conversions. If AstroLib ever drops its dependency on Dates, these can move to a package extension. It's possible to implement this ever so slightly faster and with less code re-use to avoid allocating a vector to store the Julian dates I propose adding that optimization iff someone identifies this as a performance bottle neck.