Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine 3.20 & PHP82 #1063

Open
mhzawadi opened this issue Jul 1, 2024 · 6 comments · May be fixed by #1099
Open

Alpine 3.20 & PHP82 #1063

mhzawadi opened this issue Jul 1, 2024 · 6 comments · May be fixed by #1099
Labels
dependencies Pull requests that update a dependency file future-versions php Pull requests that update Php code V2

Comments

@mhzawadi
Copy link

mhzawadi commented Jul 1, 2024

Hello 👋🏼

I have been updating all my docker images to Alpine v3.20 and that has dropped PHP81, so I cant update my InvoicePlane image as the docs say PHP >= 8.0 and =< 8.1

DO you have PHP82/83 on the roadmap for anytime soon?

@nielsdrost7
Copy link
Contributor

Hey @mhzawadi
PHP 8.2 and 8.3 are on the roadmap for InvoicePlane V2.

The V1 of InvoicePlane was built with CodeIgniter and as long as they don't get ready for PHP 8.2, InvoicePlane can't either (if that makes sense)

V2 is in the works.

@nielsdrost7 nielsdrost7 added dependencies Pull requests that update a dependency file php Pull requests that update Php code future-versions V2 labels Jul 6, 2024
@Masgalor
Copy link
Collaborator

I am really confused about what to do with this information.

Since Debian-stable ships PHP8.2 I have no way to use something below this, what can I do to run IP?
If I got it right I can either use the information from #1009 (comment) to build IPv1 myself with an unofficial fork of CI3 (that supports PHP8.2) or try IPv2 which is still in development.

But this raises the next question, where can I find IPv2? Google gives me results of people talking about fit or at least 6 years, but I can not find any repository or download or any other signs of it's existence.

So, if I really need to run IP on PHP8.2 what is the best thing I can do?

@mhzawadi
Copy link
Author

If your looking for PHP not 8.2, this is made by a Deb dev and has PHP56 and up

https://packages.sury.org/php/README.txt

@Masgalor
Copy link
Collaborator

So, if I really need to run IP on PHP8.2 what is the best thing I can do?

I am looking for the best option to run IP on PHP8.2.
But thanks for your answer anyway, it might be helpful for others.

@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Jul 26, 2024

I've answered the question about InvoicePlane V2 in this discussion

I am looking for the best option to run IP on PHP8.2.

IP & PHP 8.2:

(feel free to ask questions about below steps, if you like)

InvoicePlane was build with something that's called CodeIgniter version 3.

  1. CodeIgniter 3 (after this: CI3) has 2 things:
    a. A branch with an almost working version for them for PHP 8.2,
    b. Someone who couldn't wait and just fixed it.

In your composer.json point to either of those 2 solutions, then run composer update

  1. IP: Turn on any kind of debug you can find. error_reporting, everything. Now load IP on your PHP 8.2 with CI3 solution

  2. You'll find a couple of similar cases: assignment of Dynamic Properties. Long story, but you'll find them in your error messages.

I don't know if that's all the errors you'll find, but it's the thing that changed between PHP 8.1 and 8.2

Once the dynamic properties situation has been resolved, the rest should be fairly easy to fix (famous last words)

Hope it helps

@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Jul 27, 2024

Hey @Masgalor I've created 2 discussions for you so I can answer your questions in a better way: Discussion (and questions) about InvoicePlane and PHP 8.2
Discussion (and questions) about InvoicePlane Version 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file future-versions php Pull requests that update Php code V2
Projects
None yet
3 participants