Merge pull request Codeception#2242 from Naktibalda/iisue-2234

Disabled CookieJar strict mode in Guzzle6 connector
Green-Cat · Aug 5, 2015 · 96e8582 · 96e8582
2 parents 2579bf3 726e90d
commit 96e8582
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/Codeception/Lib/Connector/Guzzle6.php b/src/Codeception/Lib/Connector/Guzzle6.php
@@ -312,6  312,6 @@ protected function extractCookies($host)
             }
             $jar[] = $setCookie;
         }
-        return new CookieJar(true, $jar);
         return new CookieJar(false, $jar);
     }
 }
diff --git a/tests/data/app/controllers.php b/tests/data/app/controllers.php
@@ -198,4  198,10 @@ function GET() {
         header('Content-Type:', true);
         include __DIR__.'/view/content_type2.php';
     }
-}
 }
 
 class unsetCookie {
     function GET() {
         header('Set-Cookie: a=; Expires=Thu, 01 Jan 1970 00:00:01 GMT');
     }
 }
diff --git a/tests/data/app/index.php b/tests/data/app/index.php
@@ -37,6  37,7 @@
     '/register' => 'register',
     '/content-iso' => 'contentType1',
     '/content-cp1251' => 'contentType2',
     '/unset-cookie' => 'unsetCookie',
 );
 
 glue::stick($urls);
diff --git a/tests/unit/Codeception/Module/PhpBrowserTest.php b/tests/unit/Codeception/Module/PhpBrowserTest.php
@@ -361,4  361,17 @@ private function skipForOldGuzzle()
             $this->markTestSkipped("Not for Guzzle <6");
         }
     }
 
     /**
      * @issue https://github.com/Codeception/Codeception/issues/2234
      */
     public function testEmptyValueOfCookie()
     {
       //set cookie
       $this->module->amOnPage('/cookies2');
 
       $this->module->amOnPage('/unset-cookie');
       $this->module->seeResponseCodeIs(200);
       $this->module->dontSeeCookie('a');
     }
 }