Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: PHP7.4 image and solr #257

Draft
wants to merge 1 commit into
base: primary
Choose a base branch
from
Draft

Docker: PHP7.4 image and solr #257

wants to merge 1 commit into from

Conversation

marczhermo
Copy link
Collaborator

Hi there and thank you for taking the time and effort to make a Pull Request

No, seriously, we are delighted you made time and effort to help us, even in the smallest way!

Please check the following

  • Have you opened an issue to discuss the feature and agree its general design?
  • Do you have a use case and, ideally, an example program using the feature?
  • Do you have tests covering 90% of the feature code (and, of course passing)
  • Have you written complete and accurate doc comments?
  • Have you updated the README or docs where needed?
  • Code is readable
  • Code is tested
  • I've read the Code of Conduct (Or, at least, I do believe I agree with it)
  • Frontend features don't look completely uncared for
  • Code is PSR-2 compliant
  • I'm fairly sure this is useful
  • I'm not just making this PR for HacktoberFest
  • You rock. Thanks a lot.

@marczhermo marczhermo force-pushed the docker/php74-image branch from deb24aa to ae052c0 Compare May 3, 2022 12:35
@marczhermo marczhermo force-pushed the docker/php74-image branch from ae052c0 to fa66fdf Compare May 3, 2022 12:38
ssmarco
ssmarco reviewed May 3, 2022
View reviewed changes
.circleci/config.yml
@@ -50,9 51,9 @@ jobs:
environment:
CC_TEST_REPORTER_ID: 586f7041e9f71c44946cdfe8bce27d66c6271d173ec291c2a9aa7e1b56667873
docker:
- image: ssmarco/php-solr:latest
- image: ssmarco/php-solr:7.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Firesphere I got new docker image with PHP 7.4 and Solr 8.11.1 in it.
CircleCI is still failing though so will have a look at it soon.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably related to MySQL? I've had that a few times. Might be a simple case of environment variables update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssmarco ssmarco ssmarco left review comments

@Firesphere Firesphere Firesphere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marczhermo @Firesphere @ssmarco