-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time #54627
Conversation
i am completing checklist, android build is in progress |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-27.at.6.53.55.PM.movAndroid: mWeb ChromeScreen.Recording.2024-12-27.at.6.58.18.PM.moviOS: NativeiOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-27.at.18.57.18.mp4MacOS: Chrome / SafariScreen.Recording.2024-12-27.at.6.42.04.PM.movMacOS: DesktopScreen.Recording.2024-12-27.at.6.43.15.PM.mov |
@Beamanator / @puneetlath all yours! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[fix] Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time (cherry picked from commit a5feee8) (CP triggered by jasperhuangg)
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.79-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Explanation of Change
Fixed Issues
$ #54600
PROPOSAL:
Tests
Expected Result:
Only one Filter tooltip is shown.
Offline tests
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-27.at.10.52.39.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-12-27.at.10.57.16.PM.mov
iOS: Native
Screen.Recording.2024-12-27.at.10.36.09.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-12-27.at.10.31.37.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-27.at.10.07.39.PM.mov
MacOS: Desktop
Screen.Recording.2024-12-27.at.11.19.02.PM.mov