-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading images into our help site repo to be added to help articles #54435
Conversation
Adding Design images into your help site repo to be added to help articles.
This comment was marked as outdated.
This comment was marked as outdated.
@MonilBhavsar @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://2ca7e452.helpdot.pages.dev ⚡️ |
This one should be pretty easy - I'm just adding images into our repo (the assocaited GHs are in the OP). Next, I'll add them into the respective help articles. Thanks for the review! |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sonialiap |
@ @sonialiap One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
adding a new reviewer since @CortneyOfstad is ooo. @sonialiap I'm just adding images into the repo. Image GH. Next, I'll create a new PR to add the images to the help article. Can you review and approve this for me? Thank you! |
Looks good, pretty straightforward change so merging this in |
🚀 Deployed to staging by https://github.com/sonialiap in version: 9.0.79-0 🚀
|
Bill Pay images relate to: https://github.com/Expensify/Expensify/issues/444051
Article: https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Receive-and-Pay-Bills
Create an Expense images relate to: https://github.com/Expensify/Expensify/issues/438175
Article: https://help.expensify.com/articles/new-expensify/expenses-&-payments/Create-an-expense
Explanation of Change
Just adding images into our repo
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.