-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display not here page if card is deactivated #53835
Fix display not here page if card is deactivated #53835
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-11.at.15.47.38.movAndroid: mWeb ChromeScreen.Recording.2024-12-11.at.15.38.10.moviOS: NativeScreen.Recording.2024-12-11.at.15.43.16.moviOS: mWeb SafariScreen.Recording.2024-12-11.at.15.36.43.movMacOS: Chrome / SafariScreen.Recording.2024-12-11.at.15.30.56.movMacOS: DesktopScreen.Recording.2024-12-11.at.15.32.42.mov |
While reviewing this PR, I discovered new bug on Android and reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1733907323929729 |
@thelullabyy Please update test step to cover additional bug |
@DylanDylann Thanks, I updated the steps to add your point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.75-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
Explanation of Change
Fixed Issues
$ #53560
PROPOSAL: #53560 (comment)
Tests
Precondition:
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-10.at.18.13.50.mov
Android: mWeb Chrome
Screen.Recording.2024-12-10.at.17.58.38.mov
iOS: Native
Screen.Recording.2024-12-10.at.18.10.03.mov
iOS: mWeb Safari
Screen.Recording.2024-12-10.at.17.52.16.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-10.at.17.42.35.mov
MacOS: Desktop
Screen.Recording.2024-12-10.at.18.17.12.mov