-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Create Deactivate card logic #45703
Feature: Create Deactivate card logic #45703
Conversation
IMPORTANT: |
@DylanDylann @allgandalf - same here. Who's taking this? |
@Pujan92, those guys are running C on this project, so I've switched you out here. 👍 |
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-19.at.15.24.00.movAndroid: mWeb ChromeScreen.Recording.2024-07-19.at.15.20.38.moviOS: NativeScreen.Recording.2024-07-19.at.15.23.47.moviOS: mWeb SafariScreen.Recording.2024-07-19.at.15.22.11.movMacOS: Chrome / SafariScreen.Recording.2024-07-19.at.15.14.17.movMacOS: DesktopScreen.Recording.2024-07-19.at.15.19.17.mov |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward, I think Maria is off for the weekend so I will merge this one
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.11-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
@mountiny @DylanDylann Do we need to QA this in Staging? |
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀
|
|
||
Navigation.goBack(); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When deactivating the card, the Apps will show an empty page (ref: #53560) we need to close this page before removing card from Onyx
Details
CreateD Deactivate card logic
Fixed Issues
$ #44320
PROPOSAL: N/A
Tests
Pre-step:
Comment out the feature check in the WorkspaceExpensifyCardDetailsPage file, so you can access the screen.
Offline tests
Same as tests
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web