Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Edited by proposal-police: This proposal was edited at 2024-12-27 21:26:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Mentions are not shown in expensify issue card thread page instead a double space shown

What is the root cause of that problem?

For the thread header case when the assigned user hasn't set firstName BE will set it to empty string so the fallback of login here will not work as we use ?? so the assignee part will be empty

What changes do you think we should make in order to solve the problem?

We need to use || instead to deal with empty string cases

    const assignee = shouldRenderHTML ? `<mention-user accountID="${assigneeAccountID}"/>` : assigneeDetails?.firstName || (assigneeDetails?.login ?? '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write a test for getCardIssuedMessage with shouldRenderHTML as false and assert that the assignee part is not empty string when the assignee firstName is empty string

What alternative solutions did you explore? (Optional)

We are intentionally displaying the assignee part with the firstName instead of the login for when shouldRenderHTML is false if we want it to consistent with the shouldRenderHTML case we can set it directly to assigneeDetails?.login instead of firstName.

Edited by proposal-police: This proposal was edited at 2024-12-28 04:55:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mentions are not shown in expensify issue card thread page instead a double space is shown

What is the root cause of that problem?

We can reproduce this issue in WS while inviting new users and remove the existing users

In some cases, BE will return the following message

<mention-user accountID=123456></<mention-user>

In here

and

we have the logic to convert html to text but it just covers the case <mention-user accountID="123456"/>

-> the html doesn't match with the defined regex, so we don't see the mentioned users

What changes do you think we should make in order to solve the problem?

1. We should update the regex about user mention here to be the same as this place
2. But the regex here doesn't cover the case accountID is number

so we need to update it to

/(?:<mention-user accountID="?(\d )"?(?: *\/>|><\/mention-user>))|(?:<mention-user>(.*?)<\/mention-user>)/gi;

Use the same logic for mention-report
3. Use the new regex for mention-report and mention-user in parseReportActionHtmlToText and ExpensifyMark

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should add new test in htmlToText for the following cases:

• <mention-user accountID=123456></<mention-user>
• <mention-user accountID="123456"></<mention-user>
• <mention-user accountID=123456/>
• <mention-user accountID="123456"/>

and mention-report

What alternative solutions did you explore? (Optional)

In parseReportActionHtmlToText we can apply the logic to wrap accountID inside "" if it's number. Then remove the closed tag </mention-user> to use self close tag />

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result