Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Website crashes after submitting a track expense.

What is the root cause of that problem?

We removed the fallback here then the app crashes when the chatReportID is changed from an empty string to an exist ID.

What changes do you think we should make in order to solve the problem?

Bring the fallback ID back

Or when we create the track expense we should set IOUReportID of the IOU action as 0 in optimistic data since BE also returns like this.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@brunovjk can you review this above proposal?

Sure!

@nkdengineer Your proposal makes sense to me. I’ve brought back the fallback ID using CONST.DEFAULT_NUMBER_ID here, and it resolves this specific issue.

However, in the original PR, we made changes in other locations to align with the new 'default-value-for-inexistent-ids' rule. I’m concerned these changes might have unintentionally impacted other flows, that I may not have considered, potentially leading to regressions like this one. Do you see other lines with useOnyx or related logic where we should reintroduce CONST.DEFAULT_NUMBER_ID in the MoneyRequestPreviewContent.tsx? Thank you

Do you see other lines with useOnyx or related logic where we should reintroduce CONST.DEFAULT_NUMBER_ID in the MoneyRequestPreviewContent.tsx? Thank you

Bring the fallback ID back

@brunovjk The crash app will happen for the collect onyx keys then when I mentioned Bring the fallback ID that mean we need to update this for all useOnyx that connects with collection keys in MoneyRequestPreviewContent.

Or we should fallback here to -1 instead of empty string.

Great! Thanks @nkdengineer, I think we can go with their proposal.

🎀👀🎀 C reviewed

Current assignee @nkuoch is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

oops, I added 🎀 out of habit

Job added to Upwork: https://www.upwork.com/jobs/~021872615001903986307

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@brunovjk The PR is ready for review.

Great! Reviewing now.

Tests well! Thanks for the fix