Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Not a regression of PR #54147 as the issue is present on production as well and the PR was only deployed on staging, which proves that the issue was present before the PR changes.

We simply did not consider removing the duplicated entries from the mentions list as that wasn't part of the other issue's scope nor mentioned anywhere in the other issue's testing steps / actual behaviour.

Proposal

Please re-state the problem that we are trying to solve in this issue

Duplicated QA guide entries in mention suggestion list after onboarding with Manage my team's expenses.

What is the root cause of that problem?

Sometimes there's two QA guide entries in the member list after onboarding flow with Manage my team's expenses choice which seems to come from BE.

[
    {
        "text": "[email protected]",
        "alternateText": "[email protected]",
        "keyForList": "14365522",
        "isSelected": false,
        "isDisabled": false,
        "accountID": 14365522,
        "login": "[email protected]",
        "icons": [
            {
                "source": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_11.png",
                "type": "avatar",
                "name": "[email protected]",
                "id": 14365522
            }
        ],
        "reportID": ""
    },
    {
        "text": "[email protected]",
        "alternateText": "[email protected]",
        "keyForList": "714749267",
        "isSelected": false,
        "isDisabled": false,
        "accountID": 714749267,
        "login": "[email protected]",
        "icons": [
            {
                "source": "ƒ SvgFallbackAvatar(props)",
                "type": "avatar",
                "name": "[email protected]",
                "id": 714749267
            }
        ],
        "reportID": ""
    }
]

Since we don't have bandwith to investigate this on BE side as stated in this comment, we should move forward with a FE fix which simply filters out duplicated values based on login key which is a unique identifier in our app.

Similar to issue #53579 where I proposed the fix and implemented it, the mention suggestion list does not have any logic to handle duplicates in this filtering block:

which is separate from OptionsListUtils.filterAndOrderOptions where we just implemented the fix for the other issue.

What changes do you think we should make in order to solve the problem?

Same as the fix implemented in PR #54147, add the following logic to SuggestionMention component at the end of the filteredPersonalDetails block replacing return true like so:

const filteredPersonalDetails = Object.values(personalDetailsParam ?? {}).filter((detail, index, array) => { // <- access `index` and `array` of filter method
    // ... existing logic

    // on staging server, in specific cases (see issue) BE returns duplicated personalDetails entries with the same login which we need to filter out
    return array.findIndex((i) => i?.login === detail?.login) === index;
    // return true; <- replaced by the line above
}) as Array<PersonalDetails & {weight: number}>;

this will filter out duplicated entries that have the same login key value, returning true only for the unique entries.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test in compareUserInListTest.ts to ensure that dupicate login entries are filtered out, similar to the test added in PR #54147.

Result video (before / after)

Yah, I think it's not the regression from #54147, in this PR, we're trying to fix the duplicated item in as many places as possible. But there are too many places that use personalDetailsList, do you have any idea to fix them all at once? @ikevin127

do you have any idea to fix them all at once?

Not really, I think there are different places in the app where personal details are used and is not always centralized like we had for the recent PR in the utils file.

My proposal above suggests to fix the issue where or occurs, since the case of suggestions is isolated to 1 component.