Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Trip - Trip details RHP opens instead of not here page when opening invalid trip link #54537

Open
6 of 8 tasks
IuliiaHerets opened this issue Dec 24, 2024 · 13 comments
Open
6 of 8 tasks

[$250] Trip - Trip details RHP opens instead of not here page when opening invalid trip link #54537

IuliiaHerets opened this issue Dec 24, 2024 · 13 comments
Assignees
@carlosmiceli @s77rt @sonialiap
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 24, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #52823
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any report.
  3. Paste the following link https://staging.new.expensify.com/r/6732929228344392/trip/2905990518128580779/0
  4. Click on the link.

Expected Result:

Not here page will open.

Actual Result:

Trip details RHP opens with Modify Trip and Trip support button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701798_1735046644715.bandicam_2024-12-24_21-21-49-423.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021871712471050888781
  • Upwork Job ID: 1871712471050888781
  • Last Price Increase: 2024-12-25
Issue OwnerCurrent Issue Owner: @s77rt
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Dec 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Dec 24, 2024
Closed
@jasperhuangg
Copy link
Contributor

This feature is locked behind a beta, so there's no need to block deploy on it. @blazejkustra please fix this since you worked on the PR introducing trip details.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 24, 2024
@carlosmiceli
Copy link
Contributor

Thanks for triaging @jasperhuangg ! Been working all day on a couple other DBs 🙏

@jasperhuangg jasperhuangg added the DeployBlockerCash This issue or pull request should block deployment label Dec 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 24, 2024
@jasperhuangg
Copy link
Contributor

You can't access the trip details page unless you're on the beta so there's no need to block deploy on this.

@carlosmiceli carlosmiceli added the External Added to denote the issue can be worked on by a contributor label Dec 25, 2024
@melvin-bot melvin-bot bot changed the title Trip - Trip details RHP opens instead of not here page when opening invalid trip link [$250] Trip - Trip details RHP opens instead of not here page when opening invalid trip link Dec 25, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021871712471050888781

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 25, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@carlosmiceli carlosmiceli removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 25, 2024
@carlosmiceli
Copy link
Contributor

Oh, I missed this comment: #54537 (comment)

Looks like this is going to be fixed by @blazejkustra , so no need for proposals.

@carlosmiceli carlosmiceli removed the External Added to denote the issue can be worked on by a contributor label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosmiceli carlosmiceli

@s77rt s77rt

@sonialiap sonialiap

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@carlosmiceli @robertjchen @s77rt @sonialiap @jasperhuangg @IuliiaHerets