Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android - Chat - Emoji picker is jumpy when opened from context menu #54453

Open
2 of 8 tasks
lanitochka17 opened this issue Dec 22, 2024 · 11 comments
Open
2 of 8 tasks

Android - Chat - Emoji picker is jumpy when opened from context menu #54453

lanitochka17 opened this issue Dec 22, 2024 · 11 comments
Assignees
@arosiclair @mallenexpensify @kirillzyusko
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 22, 2024 •
edited by arosiclair
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause - Internal Team
Component: Chat Report View

Action Performed:

  1. Launch ND or hybrid app
  2. Open DM
  3. Send a message to the DM if there is no message
  4. Tap on the composer if keyboard is not up
  5. Long tap on the message while keyboard is up
  6. Tap Add reaction button
  7. Might need to repeat Step 4 to 6 if the emoji picker is not jumpy

Expected Result:

Emoji picker will not be jumpy when opened from context menu when keyboard is opened

Actual Result:

Emoji picker is jumpy when opened from context menu when keyboard is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6700988_1734891250375.Screen_Recording_20241223_021231_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kirillzyusko
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 22, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 22, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot mentioned this issue Dec 22, 2024
Closed
72 tasks
@lanitochka17 lanitochka17 added DeployBlocker Indicates it should block deploying the API and removed Engineering Hourly KSv2 labels Dec 22, 2024
@lanitochka17
Copy link
Author

Production:

Uploading Screenrecorder-2024-12-22-20-33-16-287.mp4…

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 22, 2024
@techievivek
Copy link
Contributor

Doesn't seem to be a backend bug so removing the Deployblocker label from it.

@techievivek techievivek removed the DeployBlocker Indicates it should block deploying the API label Dec 23, 2024
@arosiclair arosiclair added Hourly KSv2 and removed Daily KSv2 labels Dec 23, 2024
@arosiclair
Copy link
Contributor

Attempting to reproduce this in dev. I'll see if reverting a couple PRs fixes the issue.

@arosiclair
Copy link
Contributor

Reverting #54187 seems to fix it but I'm not 100% sure. @kirillzyusko can you take a look at this?

In the meantime I'm going to demote this since it's minor.

@melvin-bot melvin-bot bot mentioned this issue Dec 23, 2024
Open
8 tasks
@arosiclair arosiclair added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 23, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 23, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kirillzyusko
Copy link
Contributor

@arosiclair yes, sure, feel free to assign me on this issue 👀 Will be happy to help here!

@kirillzyusko
Copy link
Contributor

@arosiclair it's not a deploy blocker, right?

The thing is why EmojiPicker is jumpy is because we instantly change padding. And it always was looking weird. I believe with the help of keyboard-controller I can achieve smooth animations and re-work the code.

just want to understand whether it's a DeployBlocker or not (whether do we need to revert a PR and prepare a new PR that will fix prev and that issue) 🤔

@arosiclair
Copy link
Contributor

@arosiclair it's not a deploy blocker, right?

No it's not. I think it's relatively minor so I demoted this issue.

@kirillzyusko kirillzyusko mentioned this issue Dec 24, 2024
Open
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arosiclair arosiclair

@mallenexpensify mallenexpensify

@kirillzyusko kirillzyusko

Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arosiclair @mallenexpensify @kirillzyusko @techievivek @lanitochka17