Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-12-17] Jumpy "Clear filter" button when keyboard gets shown #53633

Closed
4 of 8 tasks
kirillzyusko opened this issue Dec 5, 2024 · 10 comments
Closed
4 of 8 tasks

[HOLD for payment 2024-12-17] Jumpy "Clear filter" button when keyboard gets shown #53633

kirillzyusko opened this issue Dec 5, 2024 · 10 comments
Assignees
@JmillsExpensify @youssef-lr
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kirillzyusko
Copy link
Contributor

kirillzyusko commented Dec 5, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.72
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kirillzyusko
Slack conversation (hyperlinked to channel name):

Action Performed:

  1. Go to search tab
  2. Press workspace switcher
  3. See how additional keyboard space appears (above the keyboard) and disappears
  4. Select workspace
  5. Press workspace switcher
  6. See how button gets moved higher and then return to its expected position

Expected Result:

  1. No jumps
  2. No jumps

Actual Result:

  1. For a fraction of second keyboard spacing exceeds the keyboard and we see a space above the keyboard
  2. Button should be placed in a correct position immediately

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-05.at.16.25.16.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@kirillzyusko kirillzyusko added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Dec 5, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 5, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kirillzyusko kirillzyusko mentioned this issue Dec 5, 2024
Merged
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 5, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2024

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 10, 2024
@melvin-bot melvin-bot bot changed the title Jumpy "Clear filter" button when keyboard gets shown [HOLD for payment 2024-12-17] Jumpy "Clear filter" button when keyboard gets shown Dec 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 10, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 10, 2024

@youssef-lr @JmillsExpensify @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 17, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 17, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 20, 2024

@JmillsExpensify, @youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 24, 2024

@JmillsExpensify, @youssef-lr Still overdue 6 days?! Let's take care of this!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 26, 2024

@JmillsExpensify, @youssef-lr Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@kirillzyusko
Copy link
Contributor Author

I believe the issue has been fixed so it can be closed 🙂

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

@youssef-lr youssef-lr

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JmillsExpensify @youssef-lr @kirillzyusko