Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-16] [$75] Tag - In tag details page, no spacing between Go "to and more" features #53358

Closed
4 of 8 tasks
IuliiaHerets opened this issue Dec 1, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Go to workspace settings
  3. Tap more features - enable tags
  4. Add a tag
  5. Open the tag
  6. Enter GL code and complete flow
  7. Go to workspace settings - more features - enable rules
  8. Tap tags
  9. Open a tag
  10. Note text under approver field
  11. Note no spacing between Go "to and more" features
  12. Navigate to workspace settings - category
  13. Open a category
  14. Note text under approver field
  15. Note there is spacing between Go "to and more" features

Expected Result:

In tag details page, there must spacing between Go "to and more" features.

Actual Result:

In tag details page, no spacing between Go "to and more" features but spacing in category details page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6680885_1732999724160.Screenrecorder-2024-12-01-02-06-42-644_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863808426275105630
  • Upwork Job ID: 1863808426275105630
  • Last Price Increase: 2024-12-03
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 1, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@prakashbask
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

In tag details page, there must spacing between Go "to and more" features.

What is the root cause of that problem?

There is a space missing after the Text component to render "Go to" in

<Text style={[styles.textLabel, styles.colorMuted]}>{translate('workspace.rules.categoryRules.goTo')}</Text>

What changes do you think we should make in order to solve the problem?

Add a space {' '} after the Text component that is used to render "Go to" in

<Text style={[styles.textLabel, styles.colorMuted]}>{translate('workspace.rules.categoryRules.goTo')}</Text>

This solution is similar to the space added in src/pages/workspace/categories/CategorySettingsPage.tsx

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

@VictoriaExpensify
Copy link
Contributor

Yeah we should fix this, but it seems like a super simple copy fix so I'm going to drop the bounty to $75

@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Dec 3, 2024
@melvin-bot melvin-bot bot changed the title Tag - In tag details page, no spacing between Go "to and more" features [$250] Tag - In tag details page, no spacing between Go "to and more" features Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863808426275105630

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

@VictoriaExpensify VictoriaExpensify changed the title [$250] Tag - In tag details page, no spacing between Go "to and more" features [$75] Tag - In tag details page, no spacing between Go "to and more" features Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Upwork job price has been updated to $75

@suneox
Copy link
Contributor

suneox commented Dec 3, 2024

Let's go with @prakashbask proposal

🎀 👀 🎀 C reviewed

Copy link

melvin-bot bot commented Dec 3, 2024

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 3, 2024
@grgia
Copy link
Contributor

grgia commented Dec 3, 2024

All yours @prakashbask, thank you @suneox

@prakashbask
Copy link
Contributor

Thanks @grgia . I will have the PR ready by 4-Dec

@prakashbask
Copy link
Contributor

PR is #53525

Copy link

melvin-bot bot commented Dec 6, 2024

@prakashbask, @suneox, @grgia, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2024
@grgia
Copy link
Contributor

grgia commented Dec 6, 2024

PR was merged

@grgia grgia added the Reviewing Has a PR in review label Dec 6, 2024
@melvin-bot melvin-bot bot removed Overdue Daily KSv2 labels Dec 6, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 9, 2024
@melvin-bot melvin-bot bot changed the title [$75] Tag - In tag details page, no spacing between Go "to and more" features [HOLD for payment 2024-12-16] [$75] Tag - In tag details page, no spacing between Go "to and more" features Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-16. 🎊

For reference, here are some details about the assignees on this issue:

  • @prakashbask requires payment (Needs manual offer from BZ)
  • @suneox requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 9, 2024

@suneox @VictoriaExpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@suneox
Copy link
Contributor

suneox commented Dec 15, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/49937/files#r1885753605

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. N/A: Due to it isn't an impactful bug

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

Payment Summary

Upwork Job

  • ROLE: @prakashbask paid $(AMOUNT) via Upwork (LINK)
  • ROLE: @suneox paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@VictoriaExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1863808426275105630/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@VictoriaExpensify
Copy link
Contributor

@prakashbask and @suneox I've sent you both offers in Upwork. Let me know when you have accepted them and I'll orgnaise payment

@prakashbask
Copy link
Contributor

@prakashbask and @suneox I've sent you both offers in Upwork. Let me know when you have accepted them and I'll orgnaise payment

@VictoriaExpensify Thanks. I have accepted the offer in Upwork

@suneox
Copy link
Contributor

suneox commented Dec 17, 2024

Thank you! I've accepted the offer

Copy link

melvin-bot bot commented Dec 20, 2024

@prakashbask, @suneox, @grgia, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@VictoriaExpensify
Copy link
Contributor

Payment Summary:
C: @prakashbask paid $75 via Upwork
C : @suneox paid $75 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Development

No branches or pull requests

5 participants