-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-16] [$75] Tag - In tag details page, no spacing between Go "to and more" features #53358
Comments
Triggered auto assignment to @VictoriaExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.In tag details page, there must spacing between Go "to and more" features. What is the root cause of that problem?There is a space missing after the Text component to render "Go to" in
What changes do you think we should make in order to solve the problem?Add a space {' '} after the Text component that is used to render "Go to" in
This solution is similar to the space added in src/pages/workspace/categories/CategorySettingsPage.tsx What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional) |
Yeah we should fix this, but it seems like a super simple copy fix so I'm going to drop the bounty to $75 |
Job added to Upwork: https://www.upwork.com/jobs/~021863808426275105630 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox ( |
Upwork job price has been updated to $75 |
Let's go with @prakashbask proposal 🎀 👀 🎀 C reviewed |
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
All yours @prakashbask, thank you @suneox |
Thanks @grgia . I will have the PR ready by 4-Dec |
PR is #53525 |
@prakashbask, @suneox, @grgia, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
PR was merged |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-16. 🎊 For reference, here are some details about the assignees on this issue:
|
@suneox @VictoriaExpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
|
Payment Summary
BugZero Checklist (@VictoriaExpensify)
|
@prakashbask and @suneox I've sent you both offers in Upwork. Let me know when you have accepted them and I'll orgnaise payment |
@VictoriaExpensify Thanks. I have accepted the offer in Upwork |
Thank you! I've accepted the offer |
@prakashbask, @suneox, @grgia, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Payment Summary: |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9. 0.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
In tag details page, there must spacing between Go "to and more" features.
Actual Result:
In tag details page, no spacing between Go "to and more" features but spacing in category details page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6680885_1732999724160.Screenrecorder-2024-12-01-02-06-42-644_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @VictoriaExpensifyThe text was updated successfully, but these errors were encountered: