-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to build with Clang on macOS #500
base: main
Are you sure you want to change the base?
Conversation
564d95c
to
3896521
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
3b3b750
to
30c4d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 243. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 218. Check the log or trigger a new build to see more.
cb5b500
to
17f840a
Compare
Add `set -e` in build.sh to stop build process on error
Add SYSTEM flag to add_subdirectory(".../googletest") in CMakeLists.txt to supress warnings from the inside of googletest
Replace INSTANTIATE_TEST_CASE_P, which is deprecated, with INSTANTIATE_TEST_SUITE_P in NDVerifier tests
Mark unused fields as [[maybe_unused]], because clang produces warning that becomes an error in Debug mode. Use MAYBE_UNUSED macro, because g produces warning when [[maybe_unused]] macro is present, and clang -- when it isn't.
Convert double literals to model::DoubleType and model::IntType explicitly, because otherwise clang produces a warning, that becomes an error in debug mode
Add run_tests_clang action in core_tests.yml Also, work around clang-18 bug
- Check that column is numeric *before* casting it to INumericType in DataStats::GetMedianAD - Don't process empty vector in GetPartition in gfd_validation.cpp - Disable tests causing float-to-long cast when result is infinity
Add Clang installation guide to README.md
Use simple RAII wrapper of std::thread instead of std::jthread when the latter isn't implemented (which is the case in Apple Clang)
Use custom implementations of std::bitset::_Find_dirst and _Find_next when gcc intrinsics aren't availible Use some tricks with boost::dynamic_bitset in fd_tree_bitset to avoid GCC intrinsics _Find_first and _Find_next
Use std::chrono::high_resolution_clock instead of std::chrono::_V2::high_resolution_clock in fastod/util/timer.h, because symbol versioning is gcc-specific
Make GetByte function contexpr only if std::vector::operator[] is contexpr (which isn't on old versions of GCC)
Shift bitset 1 bit left in CreateDynamicBitset (fallback variant), as it done in main (gcc intrinsic) variant. Also, rename this function for clarity.
Use system_clock everywhere instead of mix of system_clock and high_resolution_clock in Cords::ExecuteInternal
Add instructions how to build boost with clang
Link clang build with libc instead of libstc in CI Also build boost with clang in CI
Don't violate implicit noexcept(true) in AutoJoinThread's destructor
Version 1.13.0 of googletest produces "narrowing conversion" warning due to a bug (issue #4206, google/googletest#4206) when building with Clang. This bug was fixed in 1.14.0 (commit 3044657, google/googletest@3044657)
Install all LLVM packages in install-clang action in CI, not only LLVM and Clang
Use concepts to test GCC intrinsics precence, instead of SFINAE
Use stable_sort instead of sort to avoid relying on unspecified behaviour (wheter sort preserves order of equal elements)
Sort pairs by value if frequencies are equal in Cords' FrequencyHandler::InitFrequencyHandler
17f840a
to
95242e0
Compare
Use reverse iterators to traverse set in reverse order, instead of messing with normal iterators
Disable alloc-dealloc-mismatch check as it's false positive on Ubuntu (see comment in CMakeLists.txt)
Limit UB sanitizer "function" check to only our code when building with Clang on macOS
Shift bitset 1 bit left in CreateDynamicBitset (fallback variant), as it done in main (gcc intrinsic) variant. Also, rename this function for clarity.
This reverts commit 30c4d53.
95242e0
to
37233d3
Compare
Build boost insteads on installing it with brew
There's no brach "release-1.14.0" in googletest repo
Install boost into /usr/local on macOS in CI, as /usr/{lib,include,bin,etc.} are read-only
- Add fallback behaviour in hymd::utility::MdLessPairs if operator <=> for vectors isn't availible - Add explicit #include <string> in exceptions.h
Add brew Clang building isntructions to README
Add ability to build with Clang compiler (Homebrew) on macOS: