Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong configuration properties for Cosmos in Spring Cloud App Configuration App samples #657

Open
saragluna opened this issue Feb 13, 2023 · 0 comments
Labels
azure-spring All azure-spring related issues

Comments

@saragluna
Copy link
Contributor

saragluna commented Feb 13, 2023

Describe the bug
This bug was found in this Azure/azure-sdk-for-java#33165. There are two samples in https://github.com/Azure-Samples/azure-spring-boot-samples/blob/main/appconfiguration/azure-spring-cloud-appconfiguration-config/azure-spring-cloud-appconfiguration-config-convert-sample/, the initial one use KV to store the Cosmos key and other properties, and the complete one uses App Configuration KV to store the configurations.

The bootstrap.properties still uses COSMOS-KEY as the property name reference, which is not correct and over-complicated in two ways.

  • We use a key format like COSMOS-KEY in KV because Key Vault doesn't support . in the secret name, but App Configuration can perfectly support that.
  • When storing configurations in the App Configuration service, there's no need to list these properties in the bootstrap.properties or application.properties anymore.

Expected behavior
We should:

@saragluna saragluna added the azure-spring All azure-spring related issues label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

No branches or pull requests

1 participant